[Ocfs2-devel] [PATCH]2.6 mechanism for holding private inode data

Mark Fasheh mark.fasheh at oracle.com
Mon Mar 15 14:16:54 CST 2004


On Sun, Mar 14, 2004 at 02:34:40PM -0800, Rusty Lynch wrote:
> Here is a patch that stores the inode private data as you talked about above.
> There is a little more complexity because you have to handle the cases where:
> * new inodes are created via ocfs_mknod and ocfs_symlink, and we need to
>   start setting private data before ocfs_populate_inode
> * reading the root inode in ocfs_read_inode2 (2.4 kernel) or
>   ocfs_read_locked_inode (2.6 kernel) where we just directly populate the
>   inode and do not call ocfs_populate_inode()
this is good. I'm going to do some testing on this today, though it looks
pretty sane.

> There is really no difference between a 2.4 and 2.6 build (other then where
> to put the code for reading the root inode.)
Yeah, and the code is so much cleaner now too :)
Just to be sure, this covers all you need in 2.6 to get the inode stuff
going too, correct? For 2.6, it looks like you're using the generic_ip
route, which is fine if you feel that there aren't any major disadvantages
(the only thing I can think of is memory allocation related).
	--Mark

--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh at oracle.com


More information about the Ocfs2-devel mailing list