[Ocfs2-devel] [Patch] for bug 79, slab alloc error
Ling, Xiaofeng
xiaofeng.ling at intel.com
Tue Jun 8 18:24:09 CDT 2004
Is there any comments for this bug 79?
Seems it is still there in the recent SVN revision.=20
>-----Original Message-----
>From: ocfs2-devel-bounces at oss.oracle.com=20
>[mailto:ocfs2-devel-bounces at oss.oracle.com] On Behalf Of Ling, Xiaofeng
>Sent: 2004=C4=EA6=D4=C21=C8=D5 19:03
>To: ocfs2-devel at oss.oracle.com
>Subject: [Ocfs2-devel] [Patch] for bug 79, slab alloc error
>
>Not sure whether it's the suitable fix, but this patch can work.
>(Since here is called in kill_supper, why root inode shall=20
>skip ocfs_extent_map_destroy?)
>
>Index: inode.c
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>--- inode.c (revision 959)
>+++ inode.c (working copy)
>@@ -698,6 +698,9 @@
> goto bail;
> }
>
>+ ocfs_extent_map_destroy (&OCFS_I(inode)->map);
>+ ocfs_extent_map_init (&OCFS_I(inode)->map);
>+
> if (inode =3D=3D osb->root_inode) {
> LOG_TRACE_STR("this is the root inode, doing=20
>cleanup now!");
> ocfs_sync_blockdev(inode->i_sb);
>@@ -707,8 +710,6 @@
> goto bail;
> }
>
>- ocfs_extent_map_destroy (&OCFS_I(inode)->map);
>- ocfs_extent_map_init (&OCFS_I(inode)->map);
>
> down(&recovery_list_sem);
> list_del(&OCFS_I(inode)->recovery_list);
>
>=20
>
>>-----Original Message-----
>>From: Ling, Xiaofeng=20
>>Sent: 2004=C4=EA6=D4=C21=C8=D5 18:31
>>To: ocfs2-devel at oss.oracle.com
>>Subject: RE: [Ocfs2-devel] bug for the new revision
>>
>>I have found this bug is caused the memory leak of the=20
>>ocfs2_extent structure,
>>The root inode's OCFS_I(inode)->map is not freed after umount.
>>So each mount and "ls /" and umount will cause one=20
>>ocfs2_extent not free.
>>It can be seen from /proc/slabinfo
>>
>>>-----Original Message-----
>>>From: ocfs2-devel-bounces at oss.oracle.com=20
>>>[mailto:ocfs2-devel-bounces at oss.oracle.com] On Behalf Of=20
>>Ling, Xiaofeng
>>>Sent: 2004=C4=EA5=D4=C231=C8=D5 17:37
>>>To: ocfs2-devel at oss.oracle.com
>>>Subject: RE: [Ocfs2-devel] bug for the new revision
>>>
>>>The newest SVN 959 has no this bug.
>>>But I meet another bug.
>>>This happened when insert module again after I run some test on it.
>>>The follow is what I get in kgdb
>>>
>>>0xc012dbd7 in kmem_cache_create (name=3D0xd08a9b64=20
>>>"ocfs2_extent", size=3D64,
>>> offset=3D32, flags=3D143360, ctor=3D0, dtor=3D0) at slab.c:815
>>>815 BUG();=20
>>>
>>>The code in slab.c is:
>>>
>>> down(&cache_chain_sem);
>>> {
>>> struct list_head *p;
>>>
>>> list_for_each(p, &cache_chain) {
>>> kmem_cache_t *pc =3D list_entry(p, kmem_cache_t, next);
>>>
>>> /* The name field is constant - no lock needed. */
>>> if (!strcmp(pc->name, name))
>>> BUG();
>>> }
>>> }
>>>
>>>kernel is still 2.4.20
>>>
>>>>-----Original Message-----
>>>>From: ocfs2-devel-bounces at oss.oracle.com=20
>>>>[mailto:ocfs2-devel-bounces at oss.oracle.com] On Behalf Of=20
>>>Ling, Xiaofeng
>>>>Sent: 2004=C4=EA5=D4=C228=C8=D5 16:28
>>>>To: ocfs2-devel at oss.oracle.com
>>>>Subject: [Ocfs2-devel] bug for the new revision
>>>>
>>>>
>>>>I tried the new ocfs2 [SVN 957] with new format, I use the new
>>>>ocfs-tools
>>>>svn
>>>>http://oss.oracle.com/projects/ocfs-tools/src/branches/new-dir
>>>-format/=20
>>>>My step
>>>>1.mkfs.ocfs2 -m /ocfs -L ocfs -b 4 /dev/hda3
>>>>2.load_ocfs2
>>>>3.mount /dev/hda3 /ocfs=20
>>>>The mount went into uninterruptable sleep.
>>>>
>>>>
>>>>call trace by magic-sysrq
>>>>
>>>>mount D 00000000 0 1268 740 =20
>>> (NOTLB)
>>>>Call Trace: [<d08697d8>] [<c0105f8a>] [<c01060e4>] [<d086adba>]
>>>>[<d0869add>]
>>>> [<c010b458>] [<d0873dd5>] [<d0873585>] [<d08a1505>] [<d08a1f19>]
>>>>[<d08902fb>]
>>>> [<d08692a1>] [<d0897365>] [<d0895086>] [<d089530d>] [<c013c57b>]
>>>>[<c013bcbc>]
>>>> [<d08b4804>] [<c013c8d1>] [<d08b4804>] [<c014f173>] [<c014f4a0>]
>>>>[<c014f2e9>]
>>>> [<c014f921>] [<c010742f>]
>>>>
>>>>output by ksymsoops
>>>>Trace; d08697d8 <[ocfs2]ocfs_bh_sem_lookup+1f8/4c0>
>>>>Trace; c0105f8a <__down+6a/b0>
>>>>Trace; c01060e4 <__down_failed+8/c>
>>>>Trace; d086adba <[ocfs2].text.lock.KBUILD_BASENAME+5/17>
>>>>Trace; d0869add <[ocfs2]ocfs_bh_sem_lock+3d/d8>
>>>>Trace; c010b458 <call_do_IRQ+5/d>
>>>>Trace; d0873dd5 <[ocfs2]OCFS_BH_GET_DATA_READ+31/174>
>>>>Trace; d0873585 <[ocfs2]ocfs_read_bhs+6b5/ed4>
>>>>Trace; d08a1505 <[ocfs2]ocfs_chk_update_config+185/ae8>
>>>>Trace; d08a1f19 <[ocfs2]ocfs_get_config+b1/460>
>>>>Trace; d08902fb <[ocfs2]ocfs_initialize_osb+9a3/151c>
>>>>Trace; d08692a1 <[ocfs2]ocfs_bh_sem_alloc+21/34>
>>>>Trace; d0897365 <[ocfs2]ocfs_mount_volume+3d9/120c>
>>>>Trace; d0895086 <[ocfs2]__ocfs_read_super+29e/4f4>
>>>>Trace; d089530d <[ocfs2]ocfs_read_super+31/70>
>>>>Trace; c013c57b <get_sb_bdev+18b/250>
>>>>Trace; c013bcbc <get_fs_type+2c/80>
>>>>Trace; d08b4804 <[ocfs2]ocfs_fs_type+0/7c>
>>>>Trace; c013c8d1 <do_kern_mount+121/140>
>>>>Trace; d08b4804 <[ocfs2]ocfs_fs_type+0/7c>
>>>>Trace; c014f173 <do_add_mount+93/190>
>>>>Trace; c014f4a0 <do_mount+160/1b0>
>>>>Trace; c014f2e9 <copy_mount_options+79/d0>
>>>>Trace; c014f921 <sys_mount+b1/e0>
>>>>Trace; c010742f <system_call+33/38>=20
>>>>
>>>>see bug 77
>>>>_______________________________________________
>>>>Ocfs2-devel mailing list
>>>>Ocfs2-devel at oss.oracle.com
>>>>http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>>>
>>>_______________________________________________
>>>Ocfs2-devel mailing list
>>>Ocfs2-devel at oss.oracle.com
>>>http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>>
>>
>_______________________________________________
>Ocfs2-devel mailing list
>Ocfs2-devel at oss.oracle.com
>http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
More information about the Ocfs2-devel
mailing list