[Ocfs2-devel] Re: [PATCH] Adding ocfs support to blkid

Theodore Ts'o tytso at mit.edu
Wed Feb 4 20:08:19 CST 2004


On Wed, Feb 04, 2004 at 12:38:12AM -0800, Rusty Lynch wrote:
> The following patch adds ocfs support to blkid.

If I'm reading your probe function implementation correctly, you don't
actually need to reread the OCFS volume header and label, since the
first 1k of the filesystem is passed to the probe function in the buf
parameter.  This is done deliberately because the blkid library tries
very hard to read each part of the filesystem only once.  

(There is cache management that goes on in blkid_very_devname() which
tries to avoid calling llseek/read needlessly, and that's why we pass
the cached buffer to the probe functions.)

						- Ted


More information about the Ocfs2-devel mailing list