[Ocfs2-devel] [PATCH] ocfs2 support for blkid utility

[Manish Singh]

On Tue, Feb 03, 2004 at 08:48:22PM -0800, Rusty Lynch wrote:
> So... I downloaded the e2fsprog source tree and hacked the following
> patch that adds ocfs2 support.
> 
> In the probe_ocfs() function, buf contains the first kbytes of data
> from the disk, and I just grab the label, suggested mount point, and
> UUID by indexing into buf.
> 
> Some of the other probe functions define their super block structure
> in an e2fsprog header file, and then just cast buf to their own 
> super block.  Since ocfs2 structures are considerably more complex, 
> I just went with the offset method.

It'd be cleaner to declare a couple structs in probe.h and use then in
probe.c, similar to what I did for mount in:

http://oss.oracle.com/projects/ocfs/src/trunk/patches/mountocfslabel.diff

Using offsets directly is rather cryptic.

> This code would totally break if ocfs2 changes the layout of the first
> kbyte on disk.  Are there any plans to change this?

No changes are planned, since one goal is to maintain on-disk compatibility
with ocfs1 as much as possible.
 
> Would anyone have a problem with me submitting this to the e2fsprogs
> project?

Fine by me, if you take my suggestion above. ;)

-Manish