[fedfs-utils] [PATCH 02/17] nfsref: Remove redundant check for nce == NULL

Chuck Lever chuck.lever at oracle.com
Tue May 27 08:36:41 PDT 2014


If nfsref_remove_delete_fsn() is called with a NULL nce argument,
nsdb_default_nce is substituted. If there is no default, then the
function returns.

Thus a later check for nce == NULL is not necessary.

Fixes: d4550c621ad80a32d834a2e4e558bd65134b303a
Signed-off-by: Chuck Lever <chuck.lever at oracle.com>
---
 src/nfsref/remove.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/nfsref/remove.c b/src/nfsref/remove.c
index b4394c1940a7..68af0a89d493 100644
--- a/src/nfsref/remove.c
+++ b/src/nfsref/remove.c
@@ -177,11 +177,7 @@ nfsref_remove_delete_fsn(const char *junct_path)
 			fsn_uuid, nce);
 		break;
 	case FEDFS_ERR_NSDB_NONCE:
-		if (nce == NULL)
-			xlog(L_ERROR, "NSDB %s:%u has no NCE",
-				nsdb_hostname(host), nsdb_port(host));
-		else
-			xlog(L_ERROR, "NCE %s does not exist", nce);
+		xlog(L_ERROR, "NCE %s does not exist", nce);
 		break;
 	case FEDFS_ERR_NSDB_NOFSN:
 		xlog(L_ERROR, "NSDB %s:%u has no such FSN %s",




More information about the fedfs-utils-devel mailing list