[fedfs-utils] [PATCH 15/17] libnsdb: Fix NULL pointer dereference in nsdb_get_naming_contexts()

Chuck Lever chuck.lever at oracle.com
Sun May 11 14:30:11 PDT 2014


Fixes: 86a3b2e65ba419aee73f75181cd247210a15683d
Signed-off-by: Chuck Lever <chuck.lever at oracle.com>
---
 src/libnsdb/fileserver.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c
index cffea59..965f1a1 100644
--- a/src/libnsdb/fileserver.c
+++ b/src/libnsdb/fileserver.c
@@ -704,10 +704,10 @@ FedFsStatus
 nsdb_get_naming_contexts_s(nsdb_t host, char ***contexts)
 {
 	LDAPMessage *response, *message;
-	LDAP *ld = host->fn_ldap;
 	FedFsStatus retval;
 	int entries;
 	char **tmp;
+	LDAP *ld;
 
 	if (host == NULL)
 		return FEDFS_ERR_INVAL;
@@ -718,6 +718,7 @@ nsdb_get_naming_contexts_s(nsdb_t host, char ***contexts)
 	if (contexts == NULL)
 		return FEDFS_ERR_INVAL;
 
+	ld = host->fn_ldap;
 	host->fn_ldaperr = nsdb_search_nsdb_attr_s(ld, LDAP_ROOT_DSE,
 							"(objectClass=*)",
 							"namingContexts",




More information about the fedfs-utils-devel mailing list