[fedfs-utils] [PATCH 5/9] Do not look for libattr. <sys/xattr.h> is enough

Chuck Lever chuck.lever at oracle.com
Fri Jun 27 11:42:54 PDT 2014


From: Cristian Rodríguez <crrodriguez at opensuse.org>

libattr never gets used in the final build as xattr functions
are provided by glibc.
This commit avoids requiring an unused library during package build.

Including <sys/xattr.h> instead of <attr/xattr.h> removes the
package build dependency on libattr-devel [cel].

Fixes: f5c16606 (configure.ac: check for presence of libattr)
Signed-off-by: Cristian Rodríguez <crrodriguez at opensuse.org>
Signed-off-by: Chuck Lever <chuck.lever at oracle.com>
---
 configure.ac                       |    5 -----
 src/libjunction/display-junction.c |    2 +-
 src/libjunction/junction.c         |    2 +-
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/configure.ac b/configure.ac
index a35c7987bd48..f7a63cfd1b85 100644
--- a/configure.ac
+++ b/configure.ac
@@ -141,11 +141,6 @@ AC_CHECK_LIB([ssl], [SSL_CTX_new],
 		 AC_DEFINE([HAVE_LIBSSL], [1],
 			   [Define if you have libssl])],
 		[AC_MSG_ERROR([libssl not found.])])
-AC_CHECK_LIB([attr], [fgetxattr],
-		[AC_SUBST([LIBATTR], ["-lattr"])
-		 AC_DEFINE([HAVE_LIBATTR], [1],
-			   [Define if you have libattr])],
-		[AC_MSG_ERROR([libattr not found.])])
 AC_CHECK_LIB([gssapi_krb5], [gss_acquire_cred],
 		[AC_SUBST([LIBGSSAPI_KRB5], ["-lgssapi_krb5"])
 		 AC_DEFINE([HAVE_LIBGSSAPI_KRB5], [1],
diff --git a/src/libjunction/display-junction.c b/src/libjunction/display-junction.c
index ac5797b3b2fb..2e924dac82a7 100644
--- a/src/libjunction/display-junction.c
+++ b/src/libjunction/display-junction.c
@@ -35,7 +35,7 @@
 #include <locale.h>
 #include <langinfo.h>
 
-#include <attr/xattr.h>
+#include <sys/xattr.h>
 
 #include "junction.h"
 #include "junction-internal.h"
diff --git a/src/libjunction/junction.c b/src/libjunction/junction.c
index 7b7b2e4b4b12..71ccc7a0ba81 100644
--- a/src/libjunction/junction.c
+++ b/src/libjunction/junction.c
@@ -38,7 +38,7 @@
 #include <errno.h>
 #include <dirent.h>
 
-#include <attr/xattr.h>
+#include <sys/xattr.h>
 
 #include "fedfs.h"
 #include "nsdb.h"




More information about the fedfs-utils-devel mailing list