[fedfs-utils] [PATCH] Do not look for libattr. <sys/xattr.h> is enough

[Cristian Rodríguez]

El 23/06/14 18:54, Chuck Lever escribió:
> 
> On Jun 23, 2014, at 6:38 PM, Cristian Rodríguez <crrodriguez at opensuse.org> wrote:
> 
>> Of course the package build will have libattr-devel as a build 
>> dependency, since this code include <attr/xattr.h> and will fail 
>> without it.. however...the code is not even linking the attr library so 
>> it will never get used.
>>
>> AC_CHECK_LIB([attr], [fgetxattr],
>>              [AC_SUBST([LIBATTR], ["-lattr"])
>>                AC_DEFINE([HAVE_LIBATTR], [1],
>>                          [Define if you have libattr])],
>>               [AC_MSG_ERROR([libattr not found.])])
>>
>> Does not add -lattr to $LIBS and the variable LIBATTR is never 
>> referenced anywhere in the makefiles.. the build succeeds because 
>> libattr duplicates libc functionality….
> 
> Then commit f5c16606 is incorrect: configure.ac should be looking for
> the attr/xattr.h header, not the libattr.so library.

Nope, it should be only looking for <sys/xattr.h> as glibc 2.3 that
contains this functionality was released in 2002.. 12 years ago.. the
xattr functions that are provided by glibc will disappear in upcoming
releases of libattr...working on that too..






-- 
Cristian
"I don't know the key to success, but the key to failure is trying to
please everybody."