[fedfs-utils] fix a few coverity-spotted problems

[Jim Meyering]

Chuck Lever wrote:

> On Nov 30, 2011, at 4:13 PM, Jim Meyering wrote:
>
>> Chuck Lever wrote:
>>> On Nov 30, 2011, at 3:51 PM, Jim Meyering wrote:
>>>
>>>> I noticed that Jeff Layton was preparing to bring 0.7.3 into Fedora
>>>> so took a look.  I ran coverity on the latest from git and it found
>>>> a few nontrivial problems.
>>>
>>> Did you pull from 0.7-stable, or master?  The master branch is going
>>> to be the next release, and it's diverged enough that we probably need
>>> separate fixes for each branch.
>>
>> That was from master (you can see .
>> 9791768cc07b1199fcc3196a59e057fc06500a3a
>
> Once these are in master, shall I back port, or do you want to?  The
> leaks are not worrisome at this point, but something like the sloppy
> option issue is a misbehavior that should be fixed in 0.7.

I don't mind doing it.

>>> None of these have a Signed-off-by tag.  That needs to be fixed before
>>> I can accept patches.  Have a look at doc/CheckInTests for more
>>> information.
>>
>> Ok.  I hadn't seen that.
>> I'll regenerate them and repost here shortly...
>> unless you'd like something else changed, too?
>> For example, I did not try to determine which
>> commit introduced each of the bugs fixed.
>
> That's a courtesy, but not always required.  If it's not too much
> trouble, that would be nice to have.

I'll look up the -s/-v one but pass on the others, if you don't mind.
Unless you had one or two that seemed important.

> But please do mention which of these was spotted by coverity. Only the
> first patch description mentions it.

I've updated the logs and added signed-off-by lines.
Will repost in 8-10 hours.