[fedfs-utils] fix a few coverity-spotted problems

[Chuck Lever]

On Nov 30, 2011, at 3:51 PM, Jim Meyering wrote:

> I noticed that Jeff Layton was preparing to bring 0.7.3 into Fedora
> so took a look.  I ran coverity on the latest from git and it found
> a few nontrivial problems.

Did you pull from 0.7-stable, or master?  The master branch is going to be the next release, and it's diverged enough that we probably need separate fixes for each branch.

None of these have a Signed-off-by tag.  That needs to be fixed before I can accept patches.  Have a look at doc/CheckInTests for more information.

> Here are fixes for most of them.
> Most arise only on error-paths.
> 
> [PATCH 1/8] mount avoid one-byte overrun
> [PATCH 2/8] fedfsd: don't return freed memory through **pathname
> [PATCH 3/8] build: avoid automake warnings about AM_PROG_AR
> [PATCH 4/8] mount: don't make -s (sloppy) imply -v (verbose)
> [PATCH 5/8] mount: don't leak upon LDAP parse failure
> [PATCH 6/8] nsdb: don't leak a read buffer upon certfile open
> [PATCH 7/8] libsi: don't leak a struct srvinfo upon failed strdup
> [PATCH 8/8] fedfsd: don't double-free upon ENOMEM

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com