[fedfs-utils] [PATCH 01/12] build: Make new warnings easier to see
Chuck Lever
chuck.lever at oracle.com
Fri Nov 11 12:26:09 PST 2011
We want to see any newly introduced automake problems immediately, so
enable automake warnings with "-Wall -Werror".
Use "git clean" as a check-in test to help expose problems with
missing or untracked files.
Also, enable quiet building to make new compiler and linker warnings
easier to see. With "make -s" we now get:
...
Making all in nsdbparams
CC main.o
CCLD nsdbparams
Making all in resolve-junction
CC main.o
CC privilege.o
CCLD resolve-junction
...
making warnings stand out clearly.
Unfortunately I don't see a way to make silent builds the default
behavior, though: you still have to request it explicitly via:
./configure --enable-silent-rules
Signed-off-by: Chuck Lever <chuck.lever at oracle.com>
---
configure.ac | 2 +-
doc/CheckInTests | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index b26a4a7..3a4316e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,7 +34,7 @@ AC_CONFIG_MACRO_DIR([m4])
# Automake and libtools initialization
LT_INIT
-AM_INIT_AUTOMAKE
+AM_INIT_AUTOMAKE([-Wall -Werror silent-rules])
# configure command line options
AC_ARG_WITH([fedfsuser],
diff --git a/doc/CheckInTests b/doc/CheckInTests
index fc67da3..550e6d5 100644
--- a/doc/CheckInTests
+++ b/doc/CheckInTests
@@ -82,11 +82,13 @@ This is basic stuff that's easy to run, and should be working for
bisecting to be useful.
1. "autogen.sh" and "configure" must run without error
- 2. "make" must complete without error; No new compiler warnings
+ 2. "./configure --enable-silent-rules; make -s" must complete without
+ error, and without new compiler warnings
3. "make doxy" must complete with no errors or warnings
4. "make distcheck" must complete without error
5. "git status" must produce no output on a clean tree
6. "git log -p" shows no new white space damage
+ 7. "git clean -d -f -x" does not break anything
Note that to preserve bisectability, the tree MUST build after each
commit.
More information about the fedfs-utils-devel
mailing list