[fedfs-utils] [PATCH 05/12] libnsdb: don't leak upon LDAP parse failure
Chuck Lever
chuck.lever at oracle.com
Tue Dec 13 14:51:41 PST 2011
From: Jim Meyering <meyering at redhat.com>
* src/libnsdb/fileserver.c (nsdb_resolve_fsn_parse_entry): When we
fail to parse an LDAP entry, free just-allocated new->fl_dn and new.
Spotted by coverity.
Introduced by commit 0520ee72: "Initial commit," (March 29, 2011).
Signed-off-by: Jim Meyering <meyering at redhat.com>
---
src/libnsdb/fileserver.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c
index a7631e8..b22d83f 100644
--- a/src/libnsdb/fileserver.c
+++ b/src/libnsdb/fileserver.c
@@ -781,6 +781,8 @@ nsdb_resolve_fsn_parse_entry(LDAP *ld, LDAPMessage *entry,
if (retval != FEDFS_OK) {
xlog(D_CALL, "%s: parsing failed: %s",
__func__, nsdb_display_fedfsstatus(retval));
+ free(new->fl_dn);
+ free(new);
return retval;
}
More information about the fedfs-utils-devel
mailing list