[fedfs-utils] [PATCH v2 2/8] fedfsd: don't return freed memory through **pathname parameter, ...
Jim Meyering
jim at meyering.net
Thu Dec 1 04:27:13 PST 2011
From: Jim Meyering <meyering at redhat.com>
even though upon error it will not be used.
* src/fedfsd/svc.c (fedfsd_pathwalk): On an error path, don't
set *pathname at all, and certainly not to a just-freed pointer.
Spotted by coverity.
Signed-off-by: Jim Meyering <meyering at redhat.com>
---
src/fedfsd/svc.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/fedfsd/svc.c b/src/fedfsd/svc.c
index 132be70..12940c7 100644
--- a/src/fedfsd/svc.c
+++ b/src/fedfsd/svc.c
@@ -316,10 +316,12 @@ fedfsd_pathwalk(const FedFsPathName fpath, char **pathname)
xlog(D_CALL, "%s: Zero-component pathname", __func__);
strcat(result, "/");
retval = fedfsd_pathwalk_check_term(result);
- if (retval != FEDFS_OK)
+ if (retval != FEDFS_OK) {
free(result);
+ return retval;
+ }
*pathname = result;
- return retval;
+ return FEDFS_OK;
}
for (i = 0; i < fpath.FedFsPathName_len; i++) {
--
1.7.8.rc4
More information about the fedfs-utils-devel
mailing list