[fedfs-utils] fix a few coverity-spotted problems

Jim Meyering jim at meyering.net
Thu Dec 1 04:21:59 PST 2011


Chuck Lever wrote:
> On Nov 30, 2011, at 4:13 PM, Jim Meyering wrote:
>> For example, I did not try to determine which
>> commit introduced each of the bugs fixed.
>
> That's a courtesy, but not always required.  If it's not too much
> trouble, that would be nice to have.

I looked through "git log" output for the source of the
sloppy-implies-verbose bug and found it, so changed the
log message to reflect that:

    mount: don't make -s (sloppy) imply -v (verbose)

    * src/mount/main.c (main): Add a break; stmt between case 's': and
    case 'v':.  Spotted by coverity.
    Bug introduced with the initial commit of this file: 0520ee72.

    Signed-off-by: Jim Meyering <meyering at redhat.com>

The next logical question is which release is affected.
So I ran "git desc 0520ee72".  Oops.
That fails because there are no signed tags in the repository.
IMHO it is worthwhile to use gpg-signed tags, and not
just for this reason.  Here, I can easily work around
the lack by using --tags:

    $ git desc 0520ee72
    fedfs-utils-0.6.0

Normally I would leave the low-level SHA1 in the commit log, and say
"[Bug introduced in fedfs-utils-0.6.0]" in the "Bug fixes" section of
a NEWS file, e.g.,

    http://git.sv.gnu.org/cgit/coreutils.git/tree/NEWS

but I don't see any such file here.

Maintaining a NEWS file is handy because it makes it that much
easier to make a release.  As long as you impose the requirement
that each news-worthy commit also updates NEWS, most of your
release notes are already written.



More information about the fedfs-utils-devel mailing list