[DTrace-devel] [oracle/dtrace-utils] 9a314a: rawfbt: prvname is not properly set

[euloh]

  Branch: refs/heads/dev-queue
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 9a314abdb7f733a649115080f68f9b583ed7690f
      https://github.com/oracle/dtrace-utils/commit/9a314abdb7f733a649115080f68f9b583ed7690f
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2026-01-26 (Mon, 26 Jan 2026)

  Changed paths:
    M libdtrace/dt_prov_dtrace.c
    M libdtrace/dt_prov_fbt.c
    M libdtrace/dt_prov_rawtp.c
    M libdtrace/dt_prov_sdt.c
    M libdtrace/dt_provider_tp.h
    A test/unittest/providers/rawfbt/tst.wildcard-provider.d
    A test/unittest/providers/rawfbt/tst.wildcard-provider.r

  Log Message:
  -----------
  rawfbt: prvname is not properly set

The char array prvname[] is set for each provider.  It is used in the
file that implements the provider.  It might also be passed to
dt_sdt_populate() via a function argument.

However, dt_provider_tp.h also defines the macro GROUP_DATA in terms of
prvname.  In turn, GROUP_DATA is used not only in dt_prov_dtrace.c but
then again in dt_prov_fbt.c to define FBT_GROUP_DATA.

In commit 0b7c5a632 ("fbt, rawfbt: consolidate code to avoid duplication"),
the fbt and rawfbt providers are combined into a single file.  Thus, two
uses of prvname collide.  The in-file collisions get resolved, but the
cascade of macro definitions does not:  FBT_GROUP_DATA ends up using
"fbt" for both fbt and rawfbt providers.  As a result, it is possible
for rawfbt probes not to be seen.

Notice that GROUP_DATA is always paired with prp->desc->prb.  Therefore,
simply replace:
    -#define GROUP_DATA     getpid(), prvname
    +#define PROBE_DATA     getpid(), prp->desc->prv, prp->desc->prb
This makes the code more compact and relieves the macro definitions from
needing prvname.  It also makes the FBT_GROUP_DATA macro unnecessary.

The format (FMT) macro is similarly renamed and redefined to include the
probe info.

Add a test to check that a rawfbt probe can be found behind an fbt probe
when the probe description has a wildcard provider.

Orabug: 38842114
Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 2f6d75ef8a71d59e950f663e94226b1b68f073b6
      https://github.com/oracle/dtrace-utils/commit/2f6d75ef8a71d59e950f663e94226b1b68f073b6
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2026-01-26 (Mon, 26 Jan 2026)

  Changed paths:
    M Build

  Log Message:
  -----------
  Add llm directory to installed doc directory

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 1898d098a582488c9de485a9b672f6b2929335ba
      https://github.com/oracle/dtrace-utils/commit/1898d098a582488c9de485a9b672f6b2929335ba
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2026-01-26 (Mon, 26 Jan 2026)

  Changed paths:
    M libdtrace/mkvers

  Log Message:
  -----------
  Support deeper version numbers (e.g. 2.0.4.x)

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: d14411bfd0975b297eb613adf7764d0e3a1e4ecf
      https://github.com/oracle/dtrace-utils/commit/d14411bfd0975b297eb613adf7764d0e3a1e4ecf
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2026-01-26 (Mon, 26 Jan 2026)

  Changed paths:
    M NEWS
    M dtrace.spec
    M libdtrace/versions.list

  Log Message:
  -----------
  Update NEWS and dtrace.spec for release 2.0.4.1

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/1cf5e40acd5c...d14411bfd097

To unsubscribe from these emails, change your notification settings at https://github.com/oracle/dtrace-utils/settings/notifications