[DTrace-devel] [PATCH 3/4] test: Supply XFAIL for tests that use vtimestamp

[Kris Van Hees]

Given that vtimestamp is used here in a way that is not actually depending on
its meaning, I'd rather you just change the tests to not depend on vtimestamp,
but instead use something else (e.g. timestamp).

XFAILing them does not seem to e right since vtimestamp is not relevant here.

On Mon, Oct 06, 2025 at 05:57:25PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> ---
>  test/stress/fbtsafety/tst.index.d             | 2 ++
>  test/stress/fbtsafety/tst.strjoin.d           | 2 ++
>  test/stress/fbtsafety/tst.strstr.d            | 2 ++
>  test/stress/fbtsafety/tst.strtok.d            | 2 ++
>  test/stress/fbtsafety/tst.substr.d            | 2 ++
>  test/unittest/variables/bvar/tst.vtimestamp.d | 2 +-
>  6 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/test/stress/fbtsafety/tst.index.d b/test/stress/fbtsafety/tst.index.d
> index e30b94c0a..3a2e40567 100644
> --- a/test/stress/fbtsafety/tst.index.d
> +++ b/test/stress/fbtsafety/tst.index.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@xfail: dtv2: need vtimestamp support */
> +
>  #pragma D option bufsize=1000
>  #pragma D option bufpolicy=ring
>  #pragma D option statusrate=10ms
> diff --git a/test/stress/fbtsafety/tst.strjoin.d b/test/stress/fbtsafety/tst.strjoin.d
> index a22cc7943..4192bdf9e 100644
> --- a/test/stress/fbtsafety/tst.strjoin.d
> +++ b/test/stress/fbtsafety/tst.strjoin.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@xfail: dtv2: need vtimestamp support */
> +
>  #pragma D option bufsize=1000
>  #pragma D option bufpolicy=ring
>  #pragma D option statusrate=10ms
> diff --git a/test/stress/fbtsafety/tst.strstr.d b/test/stress/fbtsafety/tst.strstr.d
> index 13f4a9245..ee8512f0f 100644
> --- a/test/stress/fbtsafety/tst.strstr.d
> +++ b/test/stress/fbtsafety/tst.strstr.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@xfail: dtv2: need vtimestamp support */
> +
>  #pragma D option bufsize=1000
>  #pragma D option bufpolicy=ring
>  #pragma D option statusrate=10ms
> diff --git a/test/stress/fbtsafety/tst.strtok.d b/test/stress/fbtsafety/tst.strtok.d
> index bc0a707eb..0c5d586fb 100644
> --- a/test/stress/fbtsafety/tst.strtok.d
> +++ b/test/stress/fbtsafety/tst.strtok.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@xfail: dtv2: need vtimestamp support */
> +
>  #pragma D option bufsize=1000
>  #pragma D option bufpolicy=ring
>  #pragma D option statusrate=10ms
> diff --git a/test/stress/fbtsafety/tst.substr.d b/test/stress/fbtsafety/tst.substr.d
> index 8cd021176..ee7234473 100644
> --- a/test/stress/fbtsafety/tst.substr.d
> +++ b/test/stress/fbtsafety/tst.substr.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@xfail: dtv2: need vtimestamp support */
> +
>  #pragma D option bufsize=1000
>  #pragma D option bufpolicy=ring
>  #pragma D option statusrate=10ms
> diff --git a/test/unittest/variables/bvar/tst.vtimestamp.d b/test/unittest/variables/bvar/tst.vtimestamp.d
> index b72eb8a7f..7d92bf4cc 100644
> --- a/test/unittest/variables/bvar/tst.vtimestamp.d
> +++ b/test/unittest/variables/bvar/tst.vtimestamp.d
> @@ -4,7 +4,7 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 need vtimestamp support */
> +/* @@xfail: dtv2: need vtimestamp support */
>  
>  /*
>   * ASSERTION: The 'vtimestamp' variable can be accessed and is not -1.
> -- 
> 2.47.3
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel