[DTrace-devel] [PATCH 1/4] provider: fix registering fbt and rawfbt twice

[Eugene Loh]

On 5/1/25 11:36, Eugene Loh wrote:

> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> but the commit msg should perhaps also say that rawfbt is not needed 
> for discovery either since that's the other reason we want to be in 
> the list.

Ah.  Okay, looked at patch 2/4.  I guess another thing to do might just 
be switch the order of patches 1 and 2.

> Also, how about removing
>
> libdtrace/dt_provider.h:extern dt_provimpl_t dt_rawfbt;
>
> On 5/1/25 11:08, Kris Van Hees via DTrace-devel wrote:
>> Now that rawfbt has been integrated into the fbt provider, it no longer
>> needs to be in the list of providers to call populate() in.
>>
>> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
>> ---
>>   libdtrace/dt_provider.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/libdtrace/dt_provider.c b/libdtrace/dt_provider.c
>> index 0c621197..1e2e844e 100644
>> --- a/libdtrace/dt_provider.c
>> +++ b/libdtrace/dt_provider.c
>> @@ -36,7 +36,6 @@ const dt_provimpl_t *dt_providers[] = {
>>       &dt_lockstat,
>>       &dt_proc,
>>       &dt_profile,
>> -    &dt_rawfbt,
>>       &dt_rawtp,
>>       &dt_sched,
>>       &dt_sdt,