[DTrace-devel] [PATCH 2/2] bpf: fix have_attach_type() detection

[Kris Van Hees]

On Mon, Mar 17, 2025 at 09:36:56PM -0400, Eugene Loh wrote:
> On 3/17/25 16:20, Kris Van Hees wrote:
> 
> > On Mon, Mar 17, 2025 at 04:16:01PM -0400, Eugene Loh wrote:
> > 
> > > In what order will patches be applied?  I vote for these two ahead of the
> > > 8-patch perf series.
> > I really prefer the opposite order, mainly because the performance improvements
> > really help with speeding up the testsuite runs.
> 
> Maybe it won't matter, but the question is what one is looking for when one
> patch set is in and the other is not.  One choice is that one gets bad tests
> results... but at least they'll be faster.  The other choice is that the
> test results will still be as slow as before, but at least they'll be
> meaningful.  I vote for the latter.  (I guess the other question is what
> platform one is talking about...)  Anyhow, I vote for correctness before
> speed, but maybe we'll only test all patches at once.

There is not really an option here of having one patch set in and not the
other, so it doesn't really matter.  The perf series does not introduce any
new regressions as far as I can see, so there is no downside to applying it
first yet there is a significant benefit in terms of speeding up testing.  The
attach-type patches work around a problem with a range of kernels, which is a
problem that preceeds the perf-series already, and that fix will definitely be
in the tree right after the perf-series so the end result is good.

If easier, feel free to consider them altogether a single series rather than
two series.