[DTrace-devel] [PATCH 6/8] fbt: performance improvements

[Kris Van Hees]

On Mon, Mar 17, 2025 at 05:00:39PM -0400, Eugene Loh wrote:
> On 3/12/25 01:33, Kris Van Hees wrote:
> 
> > No change should be needed to the lockstat provider.  You uncovered a bug
> > in my patch - I'll fix it.
> 
> Just curious why lockstat even used "_*" rather than "_slowpath".

Not sure - maybe there was another variant at some point in time that is no
longer there right now.

> > Incidentally, I also just noticed that dt_modsym_mark_traceable(dtp); is being
> > done too early.  We only really need that to be done once we get to looking at
> > function symbols.  I'll move it - that way we avoid marking function traceable
> > for probes that cannot be FBT probes because of probe name or module name.
> > 
> > I'll send out a v2 tomorrow with that fix.
> 
> Okay, I think I see v2.  Just checking:  does it indeed have
> dt_modsym_mark_traceable() moved?

No, that is being done in the consolidation patch.