[DTrace-devel] [PATCH 1/3] usdt parser: remove left-over debug statement

[Kris Van Hees]

On Mon, Jun 30, 2025 at 05:38:10PM -0400, Eugene Loh via DTrace-devel wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com> ???
> 
> But what is the implication here?  That "git grep dt_dbg_usdt" shows nothing
> more?

Simply a debug statement that was needed for debugigng something during
development, but it would be spammy in a nonsense way if someone were to
define USDT_DEBUG to trace the parser.  It is useless debugging output for
anyone other than me, and even then only for one specific thing I was
debugging.

> 
> On 6/24/25 17:40, Kris Van Hees via DTrace-devel wrote:
> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> > ---
> >   libcommon/usdt_parser_notes.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/libcommon/usdt_parser_notes.c b/libcommon/usdt_parser_notes.c
> > index 0b0e1a7a..fb57f119 100644
> > --- a/libcommon/usdt_parser_notes.c
> > +++ b/libcommon/usdt_parser_notes.c
> > @@ -287,7 +287,6 @@ strarray_size(uint8_t cnt, const char *str, const char *end, size_t skip)
> >   		if (p >= end)
> >   			return -1;
> > -dt_dbg_usdt("%s: [%s] [%hhd]\n", __func__, p, *(p + strlen(p) + 1));
> >   		p += strlen(p) + 1 + skip;
> >   	}
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel