[DTrace-devel] [PATCH 2/3] test: change .r.p files from /bin/sh to /bin/bash

[Kris Van Hees]

On Mon, Jul 21, 2025 at 01:01:00PM -0400, Eugene Loh wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> I guess what I mean is that I cannot think particularly of any objection,
> but what's the rationale?  Certainly, there is still a lot of /bin/sh left.

These are some that I was ble to identify tht trigger errors or unwanted
baheviour on other distributions that do not use bash as default sh. 

> On 7/21/25 09:34, Kris Van Hees wrote:
> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> > ---
> >   test/unittest/ip/tst.ipv6localicmp.r.p                  | 2 +-
> >   test/unittest/proc/tst.signals.r.p                      | 2 +-
> >   test/unittest/providers/rawfbt/tst.synthetic-entry.r.p  | 2 +-
> >   test/unittest/providers/rawfbt/tst.synthetic-return.r.p | 4 +---
> >   test/unittest/ustack/tst.ustack25_pid.r.p               | 2 +-
> >   test/unittest/vars/tst.ucaller.r.p                      | 2 +-
> >   6 files changed, 6 insertions(+), 8 deletions(-)
> >   mode change 100755 => 120000 test/unittest/providers/rawfbt/tst.synthetic-return.r.p
> > 
> > diff --git a/test/unittest/ip/tst.ipv6localicmp.r.p b/test/unittest/ip/tst.ipv6localicmp.r.p
> > index 904102ac..fd1ef30e 100755
> > --- a/test/unittest/ip/tst.ipv6localicmp.r.p
> > +++ b/test/unittest/ip/tst.ipv6localicmp.r.p
> > @@ -1,2 +1,2 @@
> > -#!/bin/sh
> > +#!/bin/bash
> >   grep -vE '^$|data bytes|bytes from|ping statistics|packets transmitted|^rtt min'
> > diff --git a/test/unittest/proc/tst.signals.r.p b/test/unittest/proc/tst.signals.r.p
> > index 7798fa25..4044a64f 100755
> > --- a/test/unittest/proc/tst.signals.r.p
> > +++ b/test/unittest/proc/tst.signals.r.p
> > @@ -1,4 +1,4 @@
> > -#!/bin/sh
> > +#!/bin/bash
> >   #
> >   # Eliminate blank lines and the monitor messages emitted by bash.
> >   # (Turning off monitor mode should quash these, but it doesn't seem
> > diff --git a/test/unittest/providers/rawfbt/tst.synthetic-entry.r.p b/test/unittest/providers/rawfbt/tst.synthetic-entry.r.p
> > index 18171f04..59dc63b4 100755
> > --- a/test/unittest/providers/rawfbt/tst.synthetic-entry.r.p
> > +++ b/test/unittest/providers/rawfbt/tst.synthetic-entry.r.p
> > @@ -1,3 +1,3 @@
> > -#!/bin/sh
> > +#!/bin/bash
> >   uniq
> > diff --git a/test/unittest/providers/rawfbt/tst.synthetic-return.r.p b/test/unittest/providers/rawfbt/tst.synthetic-return.r.p
> > deleted file mode 100755
> > index 18171f04..00000000
> > --- a/test/unittest/providers/rawfbt/tst.synthetic-return.r.p
> > +++ /dev/null
> > @@ -1,3 +0,0 @@
> > -#!/bin/sh
> > -
> > -uniq
> > diff --git a/test/unittest/providers/rawfbt/tst.synthetic-return.r.p b/test/unittest/providers/rawfbt/tst.synthetic-return.r.p
> > new file mode 120000
> > index 00000000..7ba3ffbb
> > --- /dev/null
> > +++ b/test/unittest/providers/rawfbt/tst.synthetic-return.r.p
> > @@ -0,0 +1 @@
> > +tst.synthetic-entry.r.p
> > \ No newline at end of file
> > diff --git a/test/unittest/ustack/tst.ustack25_pid.r.p b/test/unittest/ustack/tst.ustack25_pid.r.p
> > index 6486f7ec..c0110e00 100755
> > --- a/test/unittest/ustack/tst.ustack25_pid.r.p
> > +++ b/test/unittest/ustack/tst.ustack25_pid.r.p
> > @@ -1,4 +1,4 @@
> > -#!/bin/sh
> > +#!/bin/bash
> >   # A pid entry probe places a uprobe on the first instruction of a function.
> >   # Unfortunately, this is so early in the function preamble that the function
> > diff --git a/test/unittest/vars/tst.ucaller.r.p b/test/unittest/vars/tst.ucaller.r.p
> > index 8e03f110..23255a14 100755
> > --- a/test/unittest/vars/tst.ucaller.r.p
> > +++ b/test/unittest/vars/tst.ucaller.r.p
> > @@ -1,4 +1,4 @@
> > -#!/bin/sh
> > +#!/bin/bash
> >   # A pid entry probe places a uprobe on the first instruction of a function.
> >   # Unfortunately, this is so early in the function preamble that the function