[DTrace-devel] [PATCH 2/4] provider, cg: add reject_clasue() callback

[Nick Alcock]

On 15 Jul 2025, Kris Van Hees outgrape:

> On Tue, Jul 15, 2025 at 11:35:23AM +0100, Nick Alcock wrote:
>> > +	/*
>> > +	 * Ensure the clause is valid for the probe.  Call the reject_clause()
>> > +	 * hook if defined, otherwise apply default checks.  Rejection of the
>> > +	 * clause must be reported as a compilation error.
>> > +	 */
>> > +	if (prp->prov->impl->reject_clause != NULL)
>> > +		prp->prov->impl->reject_clause(prp, sdp->dtsd_clauseflags);
>> 
>> This change applies default checks *and* the reject_clause() checks, if
>> any, not one or the other.
>
> Well, actually, the comment needs updating because with this patch there is
> no default yet.

Yeah, you might as well fix what confused me :)

-- 
NULL && (void)