[DTrace-devel] [PATCH v2 2/4] dt_impl: bump number of TSLOTS to 8

Eugene Loh eugene.loh at oracle.com
Tue Jul 1 18:31:28 UTC 2025


Very simple patch, but one key problem.  The changed line is preceded by 
a huge comment block that goes to excruciating pains to explain why the 
value should be 4.  So, I'm fine with the change itself and I think the 
"Because of the complexity..." sentence in the commit message can be 
dropped, but the comment block in the file needs to be updated to 
explain (with corresponding pains?) why we need 8 (not 9, not 7).

On 6/10/25 09:58, Alan Maguire wrote:
> Because of the complexity of the TCP translators, more tslots are
> needed.
>
> Signed-off-by: Alan Maguire <alan.maguire at oracle.com>
> ---
>   libdtrace/dt_impl.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libdtrace/dt_impl.h b/libdtrace/dt_impl.h
> index 68fb8ec5..10424f9c 100644
> --- a/libdtrace/dt_impl.h
> +++ b/libdtrace/dt_impl.h
> @@ -218,7 +218,7 @@ typedef struct dt_kern_path {
>    * - cleanpath() holds a prepended '/' char, a string, an appended '/' char,
>    *   and a terminating NUL char, or STRSZ + 3 chars altogether
>    */
> -#define DT_TSTRING_SLOTS	4
> +#define DT_TSTRING_SLOTS	8
>   #define DT_TSTRING_SIZE(dtp)	\
>   		MAX(P2ROUNDUP((dtp)->dt_options[DTRACEOPT_STRSIZE] + 3, 8), \
>   		    72)



More information about the DTrace-devel mailing list