[DTrace-devel] [oracle/dtrace-utils] a6b626: Fix fprobe/kprobe selection

[euloh]

  Branch: refs/heads/devel
  Home:   https://github.com/oracle/dtrace-utils
  Commit: a6b626a8923616dc6581d17f4769c429f2ca0d67
      https://github.com/oracle/dtrace-utils/commit/a6b626a8923616dc6581d17f4769c429f2ca0d67
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M libdtrace/dt_prov_fbt.c

  Log Message:
  -----------
  Fix fprobe/kprobe selection

In commit 2a09b3bea504 ("fbt: clean up fprobe/kprobe support"),
libdtrace/dt_prov_fbt.c populate() has this change:

    - impl = BPF_HAS(dtp, BPF_FEAT_FENTRY) ? &dt_fbt_fprobe : &dt_fbt_kprobe;
    + dt_fbt = BPF_HAS(dtp, BPF_FEAT_FENTRY) ? dt_fbt_kprobe : dt_fbt_kprobe;

That is, regardless of the BPF_HAS() test, dt_fbt_kprobe is chosen.

Restore the choice to pick up dt_fbt_fprobe when appropriate.

It is hard to devise a test for this unique problem.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>



To unsubscribe from these emails, change your notification settings at https://github.com/oracle/dtrace-utils/settings/notifications