[DTrace-devel] [PATCH 3/5] unittest/udp: update test.x now that udp provider is present

Eugene Loh eugene.loh at oracle.com
Thu Aug 28 18:06:35 UTC 2025


This really feels like it should be squashed into the 1/5 patch. How can 
one add a new provider (patch 1/5) without tests?  I understand that the 
philosophy here is to consider the entire patch series at once -- and 
splitting patches can make review easier -- but this really feels like 
part of the 1/5 patch.  To me, at least.

On 8/22/25 14:16, Alan Maguire wrote:
> Signed-off-by: Alan Maguire <alan.maguire at oracle.com>
> ---
>   test/unittest/udp/test.x | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/test/unittest/udp/test.x b/test/unittest/udp/test.x
> index d3d7a598..2ff8d675 100755
> --- a/test/unittest/udp/test.x
> +++ b/test/unittest/udp/test.x
> @@ -1,14 +1,10 @@
>   #!/bin/bash
>   #
>   # Oracle Linux DTrace.
> -# Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
> +# Copyright (c) 2017, 2025 Oracle and/or its affiliates. All rights reserved.
>   # Licensed under the Universal Permissive License v 1.0 as shown at
>   # http://oss.oracle.com/licenses/upl.
>   
> -if ! check_provider udp; then
> -        echo "Could not load udp provider"
> -        exit 1
> -fi
>   if ! perl -MIO::Socket::IP -e 'exit(0);' 2>/dev/null; then
>   	exit 1
>   fi



More information about the DTrace-devel mailing list