[DTrace-devel] [oracle/dtrace-utils] 9de4ac: test: fix typos and clarify assertions

Kris Van Hees noreply at github.com
Thu Aug 14 21:19:49 UTC 2025


  Branch: refs/heads/dev-queue
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 9de4acfd1c49089887a5b6fcbccd4b16204c9e60
      https://github.com/oracle/dtrace-utils/commit/9de4acfd1c49089887a5b6fcbccd4b16204c9e60
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2025-08-14 (Thu, 14 Aug 2025)

  Changed paths:
    M test/unittest/actions/trace/tst.array-char-multi-nul.d
    M test/unittest/actions/trace/tst.array-char-str-multi-nul.d
    M test/unittest/actions/trace/tst.array-char-str-no-nul.d
    M test/unittest/actions/trace/tst.array-char-str.d
    M test/unittest/actions/trace/tst.array-char-unprintable.d

  Log Message:
  -----------
  test: fix typos and clarify assertions

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 421d58afe1393e4edf38f81e50667722a2a7184a
      https://github.com/oracle/dtrace-utils/commit/421d58afe1393e4edf38f81e50667722a2a7184a
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2025-08-14 (Thu, 14 Aug 2025)

  Changed paths:
    M test/unittest/actions/trace/tst.array.d
    M test/unittest/actions/trace/tst.array.r

  Log Message:
  -----------
  test: improve test condition

Test with content that could be interpreted as a string if the consumer
handles things wrong.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: c7d9f2fea3e8d7af63e7915dabaaf1b537963c38
      https://github.com/oracle/dtrace-utils/commit/c7d9f2fea3e8d7af63e7915dabaaf1b537963c38
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2025-08-14 (Thu, 14 Aug 2025)

  Changed paths:
    M test/unittest/actions/trace/tst.struct-1-byte.r

  Log Message:
  -----------
  test: fix expected output for tst.struct-1-byte.d

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 8e6924a643f00609c7cfc3008031b590f85cee46
      https://github.com/oracle/dtrace-utils/commit/8e6924a643f00609c7cfc3008031b590f85cee46
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2025-08-14 (Thu, 14 Aug 2025)

  Changed paths:
    M libdtrace/dt_consume.c
    A test/unittest/actions/trace/tst.str-empty.d
    A test/unittest/actions/trace/tst.str-empty.r

  Log Message:
  -----------
  trace: handle the empty string in a sensible way

The trace("") action would dump a series of 0x00 bytes (strsize of
them) rather than printing an empty string.  While that is the legacy
behaviour, it does not really make any sense to do so.  The trace
action is described as printing data as a string if possible, and a
block of 0-bytes can certainly be printed as an empty string.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/84cc72b83cf6...8e6924a643f0

To unsubscribe from these emails, change your notification settings at https://github.com/oracle/dtrace-utils/settings/notifications



More information about the DTrace-devel mailing list