[DTrace-devel] [PATCH] Need -w for destructive actions, even if clause is not used

[Kris Van Hees]

On Fri, Aug 01, 2025 at 02:02:27PM -0400, Eugene Loh wrote:
> On 8/1/25 13:49, Kris Van Hees wrote:
> 
> > On Fri, Aug 01, 2025 at 11:36:17AM -0400, Kris Van Hees wrote:
> > > On Fri, Jul 11, 2025 at 12:40:24AM -0400, eugene.loh at oracle.com wrote:
> > > > From: Eugene Loh <eugene.loh at oracle.com>
> > > > 
> > > > If a clause includes a destructive action but -w is not used, dtrace
> > > > should not start up, even if the clause is ignored (due to -Z).
> > > > Solaris treated this as a runtime error.  We should do the same.
> > > > 
> > > > The test err.Z_no-w.sh was misguided and is replaced by a more
> > > > direct test.
> > > > 
> > > >   delete mode 100644 test/unittest/usdt/err.Z_no-w.r
> > > >   delete mode 100755 test/unittest/usdt/err.Z_no-w.sh
> > Why did you delete this test?  Isn't it still a valid test anyway, and since
> > it tests this in a more practical sense, it seems to have value.
> 
> The test was failing consistently on every platform;  it was based on
> assumptions that were eventually discarded.  So, no, not a valid test.  It
> assumed behavior different from what this commit message asserts.

Ah, overlooked that it was testing for the non-compatible behaviour.  OK.