[DTrace-devel] [PATCH 1/3] test: adjust filter

[Kris Van Hees]

On Mon, Sep 16, 2024 at 01:47:41PM -0400, Eugene Loh wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> 
> That's dense regex and makes my head hurt, but I guess it's right.
> 
> Incidentally, false positive/negative nomenclature is confusing to me:  when
> a test is positive, does it mean the test passed or failed?  How about false
> PASS/FAIL terminology instead?

That is a good point.  I've always interpreted it as being negative/positive in
terms of FAIL/PASS.  But yes, I'll try to remember to use false-FAIL/PASS in
the future for clarity.

> On 9/14/24 11:35, Kris Van Hees wrote:
> > The unittest/profile-n/tst.ufunc.sh test could report a false negative
> > due to the filter not excluding ld-linux-*.  It also did not filter out
> > unresolved addresses from the bash process.
> > 
> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> > ---
> >   test/unittest/profile-n/tst.ufunc.sh | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/test/unittest/profile-n/tst.ufunc.sh b/test/unittest/profile-n/tst.ufunc.sh
> > index 28b7c05b..13231539 100755
> > --- a/test/unittest/profile-n/tst.ufunc.sh
> > +++ b/test/unittest/profile-n/tst.ufunc.sh
> > @@ -53,7 +53,8 @@ if ! grep -q 'bash`[a-zA-Z_]' $tmpfile; then
> >   fi
> >   # Check that functions are unique.  (Exclude shared libraries and unresolved addresses.)
> > -if awk '!/^ *lib/ && !/^ *0x/ {print $1}' $tmpfile | sort | uniq -c | grep -qv " 1 "; then
> > +if awk '!/^ *(ld-linux-|lib|([^`]*`)?0x)/ {print $1}' $tmpfile | \
> > +     sort | uniq -c | grep -qv " 1 "; then
> >   	echo ERROR: duplicate ufunc
> >   	status=1
> >   fi