[DTrace-devel] [PATCH 17/22] test: Tweak spec sizes to bracket size jumps more narrowly

Eugene Loh eugene.loh at oracle.com
Tue Sep 17 18:05:43 UTC 2024


Yeah.  I think this is due to patch ordering.  The sizes depend on the 
new "Deprecate EPID" patch;  that patch, in turn, needs new sizes, 
whether narrow or not.

I guess I'll withdraw this 17/22 patch and just squash it into the 
already large 03/19 "Deprecate enabled probe ID (epid)"... v6.

On 9/14/24 14:07, Kris Van Hees wrote:
> This test gives me faqilures.
>
> runtest.log in attachment
>
> On Thu, Aug 29, 2024 at 01:22:14AM -0400, eugene.loh at oracle.com wrote:
>> From: Eugene Loh <eugene.loh at oracle.com>
>>
>> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
>> ---
>>   .../speculation/tst.SpecSizeVariations.r      | 22 -------------------
>>   .../speculation/tst.SpecSizeVariations.sh     |  2 +-
>>   2 files changed, 1 insertion(+), 23 deletions(-)
>>
>> diff --git a/test/unittest/speculation/tst.SpecSizeVariations.r b/test/unittest/speculation/tst.SpecSizeVariations.r
>> index 51f0596c..2748b307 100644
>> --- a/test/unittest/speculation/tst.SpecSizeVariations.r
>> +++ b/test/unittest/speculation/tst.SpecSizeVariations.r
>> @@ -11,26 +11,6 @@ Speculative buffer ID: 1
>>   123456706
>>   counts: 1 1
>>   
>> -Speculative buffer ID: 1
>> -123456700
>> -123456701
>> -123456702
>> -123456703
>> -123456704
>> -123456705
>> -123456706
>> -counts: 1 1
>> -
>> -Speculative buffer ID: 1
>> -123456700
>> -123456701
>> -123456702
>> -123456703
>> -123456704
>> -123456705
>> -123456706
>> -counts: 2 1
>> -
>>   Speculative buffer ID: 1
>>   123456700
>>   123456701
>> @@ -64,5 +44,3 @@ counts: 2 1
>>   dtrace: 2 speculative drops
>>   dtrace: 1 speculative drop
>>   dtrace: 1 speculative drop
>> -dtrace: 1 speculative drop
>> -dtrace: 1 speculative drop
>> diff --git a/test/unittest/speculation/tst.SpecSizeVariations.sh b/test/unittest/speculation/tst.SpecSizeVariations.sh
>> index 75e527d9..79995b59 100755
>> --- a/test/unittest/speculation/tst.SpecSizeVariations.sh
>> +++ b/test/unittest/speculation/tst.SpecSizeVariations.sh
>> @@ -9,7 +9,7 @@
>>   
>>   dtrace=$1
>>   
>> -for x in 63 64 79 80 143 144; do
>> +for x in 71 72 159 160; do
>>   	$dtrace $dt_flags -xspecsize=$x -qn '
>>   	BEGIN
>>   	{
>> -- 
>> 2.43.5
>>



More information about the DTrace-devel mailing list