[DTrace-devel] [PATCH v2 01/14] No longer depend on libsystemd
Nick Alcock
nick.alcock at oracle.com
Tue Oct 29 21:51:25 UTC 2024
On 29 Oct 2024, Kris Van Hees told this:
> You are your own enemy :) Since you chose to use all spaces for indentation
> in your configure script, you now introduced inconsistency by adding lines
> with tabs! See below...
AUGH
Maybe I should just arrange for my emacs to just fight itself all day
long.
(Of course git log --check can't simultaneously diagnose this and the
opposite problem...)
> On Mon, Oct 28, 2024 at 09:17:50PM +0000, Nick Alcock wrote:
>> diff --git a/configure b/configure
>> index 4026a3eafcd3..72eb734a8380 100755
>> --- a/configure
>> +++ b/configure
>> @@ -93,9 +93,13 @@ built locally, none of these should be needed):
>>
>> EOF
>> make help-overrides-header help-overrides-option
>> + cat >&2 <<'EOF'
>
> Leading tab whereas all other lines use spaces.
An audit reveals several such lines, actually (not all introduced by
this patch, though most were). Fixed the lot because why not. This
means we have a few extra "spurious" whitespace changes in this patch
now, e.g.
- --prefix=*) write_make_var prefix "$option";;
+ --prefix=*) write_make_var prefix "$option";;
but only a very few.
--
NULL && (void)
More information about the DTrace-devel
mailing list