[DTrace-devel] [PATCH] test: Remove duplicated check

Kris Van Hees kris.van.hees at oracle.com
Tue Nov 5 19:29:42 UTC 2024


On Mon, Nov 04, 2024 at 02:23:54PM -0500, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  test/unittest/usdt/tst.pidprobes.sh | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/test/unittest/usdt/tst.pidprobes.sh b/test/unittest/usdt/tst.pidprobes.sh
> index 8d18c89a4..25fee8553 100755
> --- a/test/unittest/usdt/tst.pidprobes.sh
> +++ b/test/unittest/usdt/tst.pidprobes.sh
> @@ -99,15 +99,6 @@ if [ $? -ne 0 ]; then
>  	cat dtrace.out
>  	exit 1
>  fi
> -echo "my result: 10" > main.out2.expected
> -if ! diff -q main.out2 main.out2.expected > /dev/null; then
> -	echo '"my result"' looks wrong when using DTrace
> -	echo === got ===
> -	cat main.out2
> -	echo === expected ===
> -	cat main.out2.expected
> -	exit 1
> -fi
>  
>  # Check that the program output is 10 when the USDT probe is enabled.
>  # That is, the PYRAMID_ENTRY_ENABLED() is-enabled checks should pass.
> @@ -115,7 +106,7 @@ fi
>  echo "my result: 10" > main.out2.expected
>  
>  if ! diff -q main.out2 main.out2.expected > /dev/null; then
> -	echo '"my result"' looks wrong
> +	echo '"my result"' looks wrong when using DTrace
>  	echo === got ===
>  	cat main.out2
>  	echo === expected ===
> -- 
> 2.43.5
> 



More information about the DTrace-devel mailing list