[DTrace-devel] [PATCH 37/38] Fix some dctx->mst->specsize comments

Kris Van Hees kris.van.hees at oracle.com
Thu Jul 18 20:41:56 UTC 2024


On Thu, Jun 27, 2024 at 01:39:03AM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  libdtrace/dt_cg.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> index d27a8cb2..1548d58f 100644
> --- a/libdtrace/dt_cg.c
> +++ b/libdtrace/dt_cg.c
> @@ -1739,7 +1739,7 @@ ok:
>  
>  		/*
>  		 * if (*((uint32_t *)&buf[DBUF_SPECID]) != 0) {
> -		 *     if (dctx->dmst->specsize + off + size >
> +		 *     if (dctx->mst->specsize + off + size >
>  		 *	   dtp->dt_options[DTRACEOPT_SPECSIZE]) {
>  		 *	   state[DT_STATE_SPEC_DROPS]++;
>  		 *
> @@ -2461,7 +2461,7 @@ dt_cg_act_setopt(dt_pcb_t *pcb, dt_node_t *dnp, dtrace_actkind_t kind)
>   * back pending a commit() or discard() for the speculation with the given id.
>   *
>   * Updates the specid in the output buffer header, rather than emitting a new
> - * record into it.  The dctx->dmst->specsize value is initialized with the size
> + * record into it.  The dctx->mst->specsize value is initialized with the size
>   * of the data thus far recorded for this speculation.
>   */
>  static void
> @@ -2491,7 +2491,7 @@ dt_cg_act_speculate(dt_pcb_t *pcb, dt_node_t *dnp, dtrace_actkind_t kind)
>  	 *		goto exit;
>  	 *	*((uint32_t *)&buf[DBUF_SPECID]) = specid;
>  	 *				// mov [%r9 + DBUF_SPECID], %dn_reg
> -	 *	dctx->dmst->specsize = spec->size;
> +	 *	dctx->mst->specsize = spec->size;
>  	 *	exit:			// nop
>  	 */
>  
> -- 
> 2.18.4
> 



More information about the DTrace-devel mailing list