[DTrace-devel] [PATCH 12/38] USDT module names may contain dots; remove incorrect check

Kris Van Hees kris.van.hees at oracle.com
Thu Jul 18 19:24:09 UTC 2024


On Thu, Jun 27, 2024 at 01:34:29AM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  libdtrace/dt_pid.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/libdtrace/dt_pid.c b/libdtrace/dt_pid.c
> index 7c7d7e30..996543b1 100644
> --- a/libdtrace/dt_pid.c
> +++ b/libdtrace/dt_pid.c
> @@ -833,14 +833,6 @@ dt_pid_create_usdt_probes(dtrace_hdl_t *dtp, dt_proc_t *dpr, dtrace_probedesc_t
>  
>  	assert(pvp->impl != NULL && pvp->impl->provide_probe != NULL);
>  
> -	if (strchr(pdp->prv, '.') != NULL ||
> -	    strchr(pdp->mod, '.') != NULL ||
> -	    strchr(pdp->fun, '.') != NULL ||
> -	    strchr(pdp->prb, '.') != NULL) {
> -		dt_dprintf("Probe component contains dots: cannot be a USDT probe.\n");
> -		return 0;
> -	}
> -
>  	if (asprintf(&probepath, "%s/probes/%i/%s/%s/%s/%s", dtp->dt_dofstash_path,
>  		     dpr->dpr_pid, pdp->prv[0] == '\0' ? "*" : pdp->prv,
>  		     pdp->mod[0] == '\0' ? "*" : pdp->mod,
> -- 
> 2.18.4
> 



More information about the DTrace-devel mailing list