[DTrace-devel] [PATCH 09/38] Fix comments that hardwire DBUF_ offsets

[Kris Van Hees]

On Thu, Jun 27, 2024 at 01:34:26AM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  libdtrace/dt_cg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> index e166d2d8..0977406a 100644
> --- a/libdtrace/dt_cg.c
> +++ b/libdtrace/dt_cg.c
> @@ -1057,8 +1057,8 @@ dt_cg_tramp_error(dt_pcb_t *pcb)
>   *
>   *	1. Store the base pointer to the output data buffer in %r9.
>   *	2. Initialize the machine state (dctx->mst).
> - *	3. Store the epid at [%r9 + 0].
> - *	4. Store 0 to indicate no active speculation at [%r9 + 4].
> + *	3. Store the epid at [%r9 + DBUF_EPID].
> + *	4. Store 0 to indicate no active speculation at [%r9 + DBUF_SPECID].
>   *	5. Evaluate the predicate expression and return if false.
>   *
>   * The dt_program() function will always return 0.
> -- 
> 2.18.4
>