[DTrace-devel] [PATCH 03/38] Get rid of apparently orphaned status[2]

Kris Van Hees kris.van.hees at oracle.com
Thu Jul 18 06:59:04 UTC 2024


On Thu, Jun 27, 2024 at 01:34:20AM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> This has apparently been replaced by the dtp component
> "dtrace_status_t dt_status[2]".

Not sure...  Even OpenSolaris already shows it as an unsused local array.  So
it is certainly deprecated.

> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  cmd/dtrace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/cmd/dtrace.c b/cmd/dtrace.c
> index 9c820686..ba1c22c5 100644
> --- a/cmd/dtrace.c
> +++ b/cmd/dtrace.c
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2022, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2024, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -916,7 +916,6 @@ main(int argc, char *argv[])
>  {
>  	dtrace_bufdesc_t buf;
>  	struct sigaction act, oact;
> -	dtrace_status_t status[2];
>  	dtrace_optval_t opt;
>  	dtrace_cmd_t *dcp;
>  
> @@ -941,7 +940,6 @@ main(int argc, char *argv[])
>  	g_argv[g_argc++] = argv[0];	/* propagate argv[0] to D as $0/$$0 */
>  	argv[0] = g_pname;		/* rewrite argv[0] for getopt errors */
>  
> -	memset(status, 0, sizeof(status));
>  	memset(&buf, 0, sizeof(buf));
>  
>  	/*
> -- 
> 2.18.4
> 



More information about the DTrace-devel mailing list