[DTrace-devel] [PATCH] ident: fix unsigned vs signed comparison

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

Incidentally, is this related to my "Supply a default probe_info()"?  
I'm still in favor of that patch, though if this ident patch goes in 
first then the commit message for the probe_info() patch needs to be 
tweaked.  Maybe the two patches should be combined???  (Maybe not.)

On 8/28/24 16:00, Kris Van Hees wrote:
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>   libdtrace/dt_ident.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libdtrace/dt_ident.c b/libdtrace/dt_ident.c
> index a4bcacd9..7c563c7c 100644
> --- a/libdtrace/dt_ident.c
> +++ b/libdtrace/dt_ident.c
> @@ -343,7 +343,7 @@ dt_idcook_args(dt_node_t *dnp, dt_ident_t *idp, int argc, dt_node_t *ap)
>   		    "matches an unstable set of probes\n", idp->di_name,
>   		    dtrace_desc2str(yypcb->pcb_pdesc, n1, sizeof(n1)));
>   
> -	if (ap->dn_value >= prp->argc)
> +	if ((int)ap->dn_value >= prp->argc)
>   		xyerror(D_ARGS_IDX, "index %lld is out of range for %s %s[ ]\n",
>   		    (long long)ap->dn_value, dtrace_desc2str(yypcb->pcb_pdesc,
>   		    n1, sizeof(n1)), idp->di_name);