[DTrace-devel] [PATCH] ioctl: remove obsolete ioctl definitions and ddead code that used them

[Kris Van Hees]

On Wed, Aug 21, 2024 at 05:48:39PM -0400, Kris Van Hees wrote:
> On Wed, Aug 21, 2024 at 04:58:44PM -0400, Eugene Loh wrote:
> > s/ddead/dead/ in subject line
> > 
> > The patch seems to leave these orphaned references:
> > 
> >     include/dtrace/dif.h: * use DTRACEIOC_CONF to dynamically obtain the
> > number of registers provided by
> 
> Will fix.
> 
> >     include/dtrace/dif_defines.h: * use DTRACEIOC_CONF to dynamically obtain
> > the number of registers provided by
> 
> Will fix.
> 
> >     libdtrace/dt_options.c: if (dt_ioctl(dtp, DTRACEIOC_DOFGET, &hdr) == -1)
> >     libdtrace/dt_options.c: if (dt_ioctl(dtp, DTRACEIOC_DOFGET, dof) == -1)
> 
> Ah yes, that function can be removed also.
> 
> > 
> > If you're getting rid of test/utils/baddof.c, then this should also go:
> > 
> >     test/utils/.gitignore:baddof
> > 
> > Also, then, what happens to "./runtest.sh --baddof"?  Shouldn't runtest.sh
> > also be cleaned up?  (Look for "baddof" and "BADDOF".)
> 
> Ah, true.  Fixing...  (I wonder where the test was that used it.)
> 
> > What happens to test/utils/badioctl.c?  Disappear?  If so, then also need to
> > clean up test/utils/Build and test/utils/.gitignore. And maybe also
> > ./runtest., although "./runtest.sh --baddof" cleanup might already take care
> > of that.
> 
> I believe that one is still in use (meant to test the DOF helper support so
> it would be testing dtprobed).

Nevermind - not used either.  Will include its removal in this patch also.