[DTrace-devel] [PATCH v2 4/9] build: --bindir is supposed to be equivalent to --sbindir

Kris Van Hees kris.van.hees at oracle.com
Fri Aug 2 05:28:58 UTC 2024


On Thu, Aug 01, 2024 at 02:21:51PM +0100, Nick Alcock wrote:
> The configure script said as much, but actually it set a
> BINDIR variable that was never used for anything.
> 
> Fix this.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  GNUmakefile | 2 --
>  configure   | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/GNUmakefile b/GNUmakefile
> index 0fc9b3b5e85c..5903a8e355f6 100644
> --- a/GNUmakefile
> +++ b/GNUmakefile
> @@ -82,8 +82,6 @@ prefix ?= /usr
>  export objdir := $(abspath build)
>  LIBDIR = $(prefix)/lib$(BITNESS)
>  INSTLIBDIR = $(DESTDIR)$(LIBDIR)
> -BINDIR = $(prefix)/bin
> -INSTBINDIR = $(DESTDIR)$(BINDIR)
>  INCLUDEDIR = $(prefix)/include
>  INSTINCLUDEDIR = $(DESTDIR)$(INCLUDEDIR)
>  SDTINCLUDEDIR = $(LIBDIR)/dtrace/include
> diff --git a/configure b/configure
> index fb9a45cda1b7..4026a3eafcd3 100755
> --- a/configure
> +++ b/configure
> @@ -125,7 +125,7 @@ for option in "$@"; do
>  	--prefix=*) write_make_var prefix "$option";;
>          --objdir=*) write_make_var objdir "$option";;
>          --libdir=*) write_make_var LIBDIR "$option";;
> -        --bindir=*) write_make_var BINDIR "$option";;
> +        --bindir=*) write_make_var SBINDIR "$option";;
>          --sbindir=*) write_make_var SBINDIR "$option";;
>          --includedir=*) write_make_var INCLUDEDIR "$option";;
>          --udevdir=*) write_make_var UDEVDIR "$option";;
> -- 
> 2.46.0.277.ge12b8151ed



More information about the DTrace-devel mailing list