[DTrace-devel] [PATCH 07/15] provider: Add support for attaching to raw tracepoints

[Nick Alcock]

On 23 Feb 2023, Kris Van Hees via DTrace-devel said:

> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

(with the below tiny niggle fixed)

> +/*
> + * Convenience function for raw  tracepoint-based probe attach.

Double space.

> + */
> +int
> +dt_tp_probe_attach_raw(dtrace_hdl_t *dtp, const dt_probe_t *prp, int bpf_fd)
> +{
> +	tp_probe_t	*tpp = prp->prv_data;
> +
> +	if (tpp->event_id != -1)
> +		tpp->event_id = INT_MAX;
> +
> +	if (tpp->event_fd == -1) {
> +		int			fd;

*Three* tabs between the type and name now? Why not just stuff in
twenty, the more the merrier, right?

-- 
NULL && (void)