[DTrace-devel] [PATCH 01/16] Remove fasttrap references and introduce pid-provider variants

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
with some minor comments below.

On 3/19/21 12:54 AM, Kris Van Hees wrote:
> Since the fasttrap provider is no longer necessary, the following
> two datatypes are being renamed:
>
> 	fasttrap_probe_type_t -> pid_probe_type_t
> 	fasttrap_probe_spec_t -> pid_probe_spec_t

The pid_*_t names have extraneous underscores;  should be 
pid_probetype_t and pid_probespec_t.

> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
>
> diff --git a/include/dtrace/pid.h b/include/dtrace/pid.h
> +typedef enum pid_probetype {
> +	DTFTP_NONE = 0,
> +	DTFTP_ENTRY,
> +	DTFTP_RETURN,
> +	DTFTP_OFFSETS,
> +	DTFTP_POST_OFFSETS,
> +	DTFTP_IS_ENABLED
> +} pid_probetype_t;

You are cleaning the names up so meticulously, it's funny to see these 
vestigial DTFTP_* prefixes here.  Wouldn't DTPPT_* or something be more 
consistent?