[Btrfs-devel][PATCH]Fix for btrfs_drop_extents

Yan Zheng yanzheng at 21cn.com
Wed Jan 30 08:40:34 PST 2008


Hello,

When truncating a inline extent, btrfs_drop_extents doesn't properly
handle the case "key.offset > inline_limit". This bug can only happen
when max line size is larger than 8K.

Attachment is the test case.

Regards
YZ
---
diff -r 96b323332c3b file.c
--- a/file.c	Tue Jan 29 16:06:37 2008 -0500
+++ b/file.c	Thu Jan 31 00:39:29 2008 +0800
@@ -591,8 +591,7 @@ next_slot:
 				}
 			}
 			bookend = 1;
-			if (found_inline && start <= key.offset &&
-			    inline_limit < extent_end)
+			if (found_inline && start <= key.offset)
 				keep = 1;
 		}
 		/* truncate existing extent */
@@ -672,11 +671,10 @@ next_slot:
 			if (!bookend)
 				continue;
 		}
-		if (bookend && found_inline && start <= key.offset &&
-		    inline_limit < extent_end && key.offset <= inline_limit) {
+		if (bookend && found_inline && start <= key.offset) {
 			u32 new_size;
 			new_size = btrfs_file_extent_calc_inline_size(
-						   extent_end - inline_limit);
+						   extent_end - end);
 			btrfs_truncate_item(trans, root, path, new_size, 0);
 		}
 		/* create bookend, splitting the extent in two */
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.c
Type: text/x-csrc
Size: 680 bytes
Desc: not available
Url : http://oss.oracle.com/pipermail/btrfs-devel/attachments/20080131/ae09680b/test.bin


More information about the Btrfs-devel mailing list