[Btrfs-devel] Re: [ANNOUNCE] Btrfs v0.12 released

David Miller davem at davemloft.net
Mon Feb 11 22:43:38 PST 2008


From: Chris Mason <chris.mason at oracle.com>
Date: Mon, 11 Feb 2008 08:42:20 -0500

> The kernel is actually worse, because the set/get macros are more complex.  
> Some live in ctree.h like in the progs, but the nasty ones live in 
> struct-funcs.c

This is really problematic, because you've got these things called
"btrfs_item_ptr()" which really isn't a pointer, it's a relative
'unsigned long' offset cast to a pointer.  The source of this
seems to be btrfs_leaf_data().

And then those things get passed down into the SETGET functions!

Then deeper down we have terribly inconsistent things like
btrfs_item_nr_offset() and
btrfs_item_offset_nr().

Sigh... I'll see what I can do.



More information about the Btrfs-devel mailing list