[Btrfs-devel] Re: [PATCH] btrfs: fixes for kobject changes in mainline

[Greg KH]

On Thu, Feb 07, 2008 at 10:20:55AM -0500, Chris Mason wrote:
> On Wednesday 06 February 2008, Greg KH wrote:
> > On Wed, Feb 06, 2008 at 01:05:10PM -0500, Chris Mason wrote:
> > > On Wednesday 06 February 2008, Greg KH wrote:
> > > > On Wed, Feb 06, 2008 at 09:01:30AM -0800, Greg KH wrote:
> > > > > Here's a patch against the unstable tree that gets the code to build
> > > > > against Linus's current tree (2.6.24-git12).  This is needed as the
> > > > > kobject/kset api has changed there.
> > >
> > > Many thanks for these updates.
> > >
> > > > > I tried to make the smallest changes needed, and it builds and loads
> > > > > successfully, but I don't have a btrfs volume anywhere (yet) to try
> > > > > to see if things still work properly :)
> > > >
> > > > Ok, I created a file for the fs, ran mkfs.btrfs on it, mounted it
> > > > loopback through the loop block driver, and then tried to mount it.
> > > >
> > > > Lovely oops in btrfs_search_slot it can be seen at:
> > > > 	http://www.kerneloops.org/raw.php?rawid=3304&msgid=
> > > >
> > > > Note, I'm running unstable for both the kernel module, and the
> > > > userspace tools...
> > > >
> > > > Was this something that I caused with the sysfs change?  Or should I
> > > > not be testing this with a loopback filesystem?
> > >
> > > btrfs on top of loopback works fine here for btrfs-unstable.  Given the
> > > oops, I'd guess someone is freeing the name field instead of strduping
> > > it.
> >
> > Would that have been due to my sysfs change?  or something else?
> 
> Looking through your patch and the funcs it calls, I don't see how it could 
> cause this oops.
> 
> It is possible you just made it compile but that 2.6.25 is causing other 
> problems.  So, I'll let the merge window settle and try again ;)

Ok, good, I'll not worry about it then :)

Oh, about the sysfs lifetime rules.  The use of kobjects here can really
be cleaned up and fixed a lot.  Let me know when you have things working
on the 2.6.25-rc kernels and I'll be glad to make those changes for you.

thanks,

greg k-h