[btrfs-devel][patch]Fix ENOTEMPTY check in btrfs_rmdir

Chris Mason chris.mason at oracle.com
Thu Oct 25 12:29:27 PDT 2007


On Thu, 25 Oct 2007 19:30:47 +0800
"Yan Zheng" <yanzheng at 21cn.com> wrote:

> Hello,
> 
> The ENOTEMPTY check in btrfs_rmdir isn't reliable. It's possible that
> the backward search finds . or .. at first, then some other directory
> entry. In that case,  btrfs_rmdir delete . or .. improperly.  The
> patch also fix a fs_mutex unlock issue in  btrfs_rmdir by the way.

Thanks, you're right.  The original code was before the inode number
index, when the backward search was correct.

-chris



More information about the Btrfs-devel mailing list