Fwd: [Btrfs-devel] [RFC] implement xattrs for btrfs

[Aneesh Kumar]

Forgot to do reply-all

---------- Forwarded message ----------
From: Aneesh Kumar <aneesh.kumar at gmail.com>
Date: Aug 29, 2007 3:25 PM
Subject: Re: [Btrfs-devel] [RFC] implement xattrs for btrfs
To: Josef Bacik <jbacik at redhat.com>


On 8/29/07, Josef Bacik <jbacik at redhat.com> wrote:
> Hello,
>
> This is my quick preview of what I'm doing so I can fix any of the major design
> flaws now.  For the most part, every filesystem implements different extended
> attribute handlers for each prefix, so ext3 has a different handler for "user.",
> "security.", "trusted." etc.  The problem with this is that none of the handlers
> seem to do anything different between each of the prefixes, you just get alot
> more code and abstraction than I think is necesary.  So the only thing I do is
> check to make sure the prefix is something that we support, and then handle
> everything the same way.  Is this a bad idea?  Let me know now so I can still
> change it :).  Right now setfatter and getfattr are the only things that work,
> so this is how I test it
>
> setfattr -n "user.myname" -v "myvalue" /mnt/btrfs-test/default/blah
> getfattr -n "user.myname" /mnt/btrfs-test/default/blah
>
> which works fine.  I embed the value into the dir_item,

Isn't the name dir_item bit confusing to take Xattr ? How difficult it would be
to have a xattr_item even though it duplicate most of dir_item

-aneesh