[Btrfs-devel] [RFC] fsync patch take 5?

[Chris Mason]

On Fri, 10 Aug 2007 11:58:45 -0400
Josef Bacik <jwhiter at redhat.com> wrote:

> Hello,
> 
> Ok here's the new patch, all tested and pretty with the suggestions
> you made yesterday.  As always, let me know if you need me to change
> anything.  If there are no objections I'll move on to fixing block
> accounting.  Thank you,
> 

It looks good to me, I'll give it a spin here as well.  One question:

>  	mutex_lock(&root->fs_info->fs_mutex);
> +	if (!BTRFS_I(inode)->last_trans)
> +		goto out;
> +	mutex_lock(&root->fs_info->trans_mutex);
> +	if (BTRFS_I(inode)->last_trans <=
> +	    root->fs_info->last_trans_committed) {
> +		BTRFS_I(inode)->last_trans = 0;

Why do we set last_trans to zero if we're about to commit?  If someone
comes in and does a second fsync, we want to keep the last_trans
recorded so the optimization can continue, right?

-chris