[BDB 11gR2 Beta] Using FTS2 with the BDB SQLite compatibility library code [#18385]
Alex Gorrod
alexander.gorrod at oracle.com
Wed Mar 3 14:23:48 PST 2010
Hi,
Those look like the correct places to add the code. You'll probably need
two additional steps:
1) Run a script from the "db-5.0.XX/dist" directory, called "s_sql". Like:
$ cd db-5.0.11/dist
$ ./s_sql
This step generates the equivalent to the SQLite amalgamated source
file. You need to have a shell prompt (not a DOS prompt), and have Tcl
installed.
2) Re-run configure. Since you're changing a header. This might not be
necessary, but won't hurt.
- Alex
On 4/03/2010 9:14 AM, Hexxeh wrote:
> Hi,
>
> I'll take a look at those in a second. Made the change regarding the
> preload function, however, when I rebuild the library, it doesn't appear
> to be going into it? Running strings libsqlite3.so | grep sqlite doesn't
> show the function name, but does show many others; and the Chromium
> compile process doesn't think it's there either.
>
> I added the prototype into sql/sqlite/src/sqlite.h.in
> <http://sqlite.h.in> and the declaration into sql/sqlite/src/global.c:
> is this correct?
>
> Regards,
> Liam
>
> On 3 March 2010 21:52, Alex Gorrod <alexander.gorrod at oracle.com
> <mailto:alexander.gorrod at oracle.com>> wrote:
>
> Hi,
>
>
> On 4/03/2010 3:07 AM, Hexxeh wrote:
>
> I think the other problem encountered in the build was these
> functions
> that haven't been exposed:
>
> - Exposed three functions that deal with unused file
> descriptors in
> 152
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l152>
>
> os_unix.c, to allow Chromium's Posix VFS implementation in
> 153
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l153>
>
>
> WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp
> 154
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l154>
>
> to correctly implement the "unused file descriptors" logic
> in the
> 155
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l155>
>
> xDlOpen() method. The new functions are
> 156
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l156>
>
> chromium_sqlite3_get_reusable_file_handle(),
> 157
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l157>
>
> chromium_sqlite3_update_reusable_file_handle() and
> 158
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l158>
>
> chromium_sqlite3_destroy_reusable_file_handle(). Also, added the
> 159
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l159>
>
> chromium_sqlite3_fill_in_unix_sqlite3_file() function that calls
> 160
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l160>
>
> fillInUnixFile(), which will be made static again as soon as a
> 161
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l161>
>
> WebKit patch using the new function lands.
>
>
> Could you clarify what this patch is used for please. I'll add some
> context. Berkeley DB SQL does not use the SQLite VFS code - it is
> one of the components that has been replaced.
>
> So, if those functions need to be exposed so that you can modify the
> behavior of SQLite (by implementing a custom VFS), then your changes
> should no longer be necessary.
>
> Thanks,
> Alex
>
>
>
>
> _______________________________________________
> BDB-BETA-FEEDBACK mailing list
> BDB-BETA-FEEDBACK at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/bdb-beta-feedback
More information about the BDB-BETA-FEEDBACK
mailing list