[BDB 11gR2 Beta] Using FTS2 with the BDB SQLite compatibility library code [#18385]

Alex Gorrod alexander.gorrod at oracle.com
Wed Mar 3 13:52:37 PST 2010


Hi,

On 4/03/2010 3:07 AM, Hexxeh wrote:
> I think the other problem encountered in the build was these functions
> that haven't been exposed:
>
>   - Exposed three functions that deal with unused file descriptors in
> 152
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l152>
>     os_unix.c, to allow Chromium's Posix VFS implementation in
> 153
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l153>
>     WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp
> 154
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l154>
>     to correctly implement the "unused file descriptors" logic in the
> 155
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l155>
>     xDlOpen() method. The new functions are
> 156
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l156>
>     chromium_sqlite3_get_reusable_file_handle(),
> 157
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l157>
>     chromium_sqlite3_update_reusable_file_handle() and
> 158
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l158>
>     chromium_sqlite3_destroy_reusable_file_handle(). Also, added the
> 159
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l159>
>     chromium_sqlite3_fill_in_unix_sqlite3_file() function that calls
> 160
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l160>
>     fillInUnixFile(), which will be made static again as soon as a
> 161
> </cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l161>
>     WebKit patch using the new function lands.

Could you clarify what this patch is used for please. I'll add some 
context. Berkeley DB SQL does not use the SQLite VFS code - it is one of 
the components that has been replaced.

So, if those functions need to be exposed so that you can modify the 
behavior of SQLite (by implementing a custom VFS), then your changes 
should no longer be necessary.

Thanks,
Alex



More information about the BDB-BETA-FEEDBACK mailing list