[rds-devel] [PATCH v4 1/1] net:rds: Fix possible deadlock in rds_message_put
patchwork-bot+netdevbpf at kernel.org
patchwork-bot+netdevbpf at kernel.org
Tue Feb 13 09:50:29 UTC 2024
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni at redhat.com>:
On Thu, 8 Feb 2024 19:28:54 -0700 you wrote:
> From: Allison Henderson <allison.henderson at oracle.com>
>
> Functions rds_still_queued and rds_clear_recv_queue lock a given socket
> in order to safely iterate over the incoming rds messages. However
> calling rds_inc_put while under this lock creates a potential deadlock.
> rds_inc_put may eventually call rds_message_purge, which will lock
> m_rs_lock. This is the incorrect locking order since m_rs_lock is
> meant to be locked before the socket. To fix this, we move the message
> item to a local list or variable that wont need rs_recv_lock protection.
> Then we can safely call rds_inc_put on any item stored locally after
> rs_recv_lock is released.
>
> [...]
Here is the summary with links:
- [v4,1/1] net:rds: Fix possible deadlock in rds_message_put
https://git.kernel.org/netdev/net/c/f1acf1ac84d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
More information about the rds-devel
mailing list