[rds-devel] [PATCH] net/rds: Use ERR_PTR for rds_message_alloc_sgs()

David Miller davem at davemloft.net
Wed Apr 15 12:33:44 PDT 2020


From: Jason Gunthorpe <jgg at ziepe.ca>
Date: Tue, 14 Apr 2020 20:02:07 -0300

> From: Jason Gunthorpe <jgg at mellanox.com>
> 
> Returning the error code via a 'int *ret' when the function returns a
> pointer is very un-kernely and causes gcc 10's static analysis to choke:
> 
> net/rds/message.c: In function ‘rds_message_map_pages’:
> net/rds/message.c:358:10: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   358 |   return ERR_PTR(ret);
> 
> Use a typical ERR_PTR return instead.
> 
> Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>

Applied, thanks.


More information about the rds-devel mailing list